From 6e22a6ba68a6270fa2ec85feab8163bab8523c55 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 14 Dec 2010 17:38:18 +0000 Subject: [PATCH] tools/hotplug: Do not mind if "ip link set" fails on vif backends Most versions of netback do not support setting the MAC address. This means that c/s 937488219719 causes the hotplug script to break for vifs, even as it fixes the bridge-wrong-MAC-address problem for tap devices (used for emulated nics). The mac-setting operation is not necessary for vifs since they are hardcoded to fe:ff* anyway. As a band-aid, add "|| true" to the call to ip link, so that this error does not cause the hotplug operation to fail. There will still be an error message printed until we can fix this better. Suggested-by: Ian Campbell Signed-off-by: Ian Jackson --- tools/hotplug/Linux/xen-network-common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 3157a10618..1100757c82 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -90,7 +90,7 @@ setup_bridge_port() { # largest non-broadcast address to prevent the address getting # stolen by an Ethernet bridge for STP purposes. # (FE:FF:FF:FF:FF:FF) - ip link set ${dev} address fe:ff:ff:ff:ff:ff + ip link set ${dev} address fe:ff:ff:ff:ff:ff || true # ... and configure it ip addr flush ${dev} -- 2.30.2